fix: throw `MockException` when `HttpClient` is not mockable by vbreuss · Pull Request #367 · aweXpect/Mockolate

vbreuss · 2026-01-15T16:58:14Z

This PR improves error handling for HttpClient mocking by throwing a clear MockException when attempting to setup or verify an HttpClient that was not properly mocked with a mockable HttpMessageHandler.

Key Changes:

Replaced fallback logic that attempted to mock HttpClient directly with explicit exception throwing
Added validation to ensure ConstructorParameters array has elements before accessing
Added comprehensive test coverage for the error scenarios across all HTTP methods

Copilot

Pull request overview

This PR improves error handling for HttpClient mocking by throwing a clear MockException when attempting to setup or verify an HttpClient that was not properly mocked with a mockable HttpMessageHandler.

Changes:

Replaced fallback logic that attempted to mock HttpClient directly with explicit exception throwing
Added validation to ensure ConstructorParameters array has elements before accessing
Added comprehensive test coverage for the error scenarios across all HTTP methods

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
Source/Mockolate/Web/HttpClientExtensions.cs	Removed unused `CastToMockOrThrow` helper method
Source/Mockolate/Web/HttpClientExtensions.Setup.Delete.cs	Replaced fallback logic with exception throwing and added length check
Source/Mockolate/Web/HttpClientExtensions.Setup.Get.cs	Replaced fallback logic with exception throwing and added length check
Source/Mockolate/Web/HttpClientExtensions.Setup.Patch.cs	Replaced fallback logic with exception throwing and added length check
Source/Mockolate/Web/HttpClientExtensions.Setup.Post.cs	Replaced fallback logic with exception throwing and added length check
Source/Mockolate/Web/HttpClientExtensions.Setup.Put.cs	Replaced fallback logic with exception throwing and added length check
Source/Mockolate/Web/HttpClientExtensions.Verify.Delete.cs	Replaced fallback logic with exception throwing and added length check
Source/Mockolate/Web/HttpClientExtensions.Verify.Get.cs	Replaced fallback logic with exception throwing and added length check
Source/Mockolate/Web/HttpClientExtensions.Verify.Patch.cs	Replaced fallback logic with exception throwing and added length check
Source/Mockolate/Web/HttpClientExtensions.Verify.Post.cs	Replaced fallback logic with exception throwing and added length check
Source/Mockolate/Web/HttpClientExtensions.Verify.Put.cs	Replaced fallback logic with exception throwing and added length check
Tests/Mockolate.Tests/Web/HttpClientExtensionsTests.Setup.DeleteTests.cs	Added tests for string and Uri overloads without mocked handler
Tests/Mockolate.Tests/Web/HttpClientExtensionsTests.Setup.GetTests.cs	Added tests for string and Uri overloads without mocked handler
Tests/Mockolate.Tests/Web/HttpClientExtensionsTests.Setup.PatchTests.cs	Added tests for string and Uri overloads without mocked handler
Tests/Mockolate.Tests/Web/HttpClientExtensionsTests.Setup.PostTests.cs	Added tests for string and Uri overloads without mocked handler
Tests/Mockolate.Tests/Web/HttpClientExtensionsTests.Setup.PutTests.cs	Added tests for string and Uri overloads without mocked handler
Tests/Mockolate.Tests/Web/HttpClientExtensionsTests.Verify.DeleteTests.cs	Added tests for string and Uri overloads without mocked handler
Tests/Mockolate.Tests/Web/HttpClientExtensionsTests.Verify.GetTests.cs	Added tests for string and Uri overloads without mocked handler
Tests/Mockolate.Tests/Web/HttpClientExtensionsTests.Verify.PatchTests.cs	Added tests for string and Uri overloads without mocked handler
Tests/Mockolate.Tests/Web/HttpClientExtensionsTests.Verify.PostTests.cs	Added tests for string and Uri overloads without mocked handler
Tests/Mockolate.Tests/Web/HttpClientExtensionsTests.Verify.PutTests.cs	Added tests for string and Uri overloads without mocked handler

github-actions · 2026-01-15T17:03:05Z

🚀 Benchmark Results

Details

BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.3 LTS (Noble Numbat)

AMD EPYC 7763 2.64GHz, 1 CPU, 4 logical and 2 physical cores

.NET SDK 10.0.102

[Host] : .NET 10.0.2 (10.0.2, 10.0.225.61305), X64 RyuJIT x86-64-v3
Job=InProcess  Toolchain=InProcessEmitToolchain  IterationCount=15

LaunchCount=1  WarmupCount=10

Method	Mean	Error	StdDev	Gen0	Gen1	Allocated
Simple_Mockolate	1.555 μs	0.0253 μs	0.0236 μs	0.2270	-	3.72 KB
Simple_Moq	175.599 μs	0.8487 μs	0.7087 μs	0.4883	-	14.55 KB
Simple_NSubstitute	5.663 μs	0.0174 μs	0.0136 μs	0.5569	0.0076	9.14 KB
Simple_FakeItEasy	6.297 μs	0.0725 μs	0.0678 μs	0.4959	-	8.11 KB

github-actions · 2026-01-15T17:03:08Z

Test Results

14 files ± 0 14 suites ±0 6m 41s ⏱️ + 1m 26s
2 187 tests + 22 2 186 ✅ + 22 1 💤 ±0 0 ❌ ±0
14 640 runs +150 14 639 ✅ +150 1 💤 ±0 0 ❌ ±0

Results for commit aacf9f2. ± Comparison against base commit ecb3045.

♻️ This comment has been updated with latest results.

Copilot

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.

sonarqubecloud · 2026-01-17T16:07:19Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-01-17T16:43:59Z

This is addressed in release v0.52.0.

vbreuss self-assigned this Jan 15, 2026

Copilot AI review requested due to automatic review settings January 15, 2026 16:58

vbreuss added the bug Something isn't working label Jan 15, 2026

Copilot AI reviewed Jan 15, 2026

View reviewed changes

vbreuss enabled auto-merge (squash) January 15, 2026 16:59

Copilot AI review requested due to automatic review settings January 15, 2026 17:34

Copilot AI reviewed Jan 15, 2026

View reviewed changes

vbreuss added 4 commits January 17, 2026 17:00

fix: throw MockException when HttpClient is not mockable

94ef303

Fix review issues

2a180b0

Simplify implementation

342d643

Add additional tests

aacf9f2

vbreuss force-pushed the topic/throw-mockexception-when-httpclient-is-not-mockable branch from 532255d to aacf9f2 Compare January 17, 2026 16:00

Copilot AI review requested due to automatic review settings January 17, 2026 16:00

Copilot AI reviewed Jan 17, 2026

View reviewed changes

vbreuss merged commit dfdf4fd into main Jan 17, 2026
9 of 10 checks passed

vbreuss deleted the topic/throw-mockexception-when-httpclient-is-not-mockable branch January 17, 2026 16:07

github-actions bot added the state: released The issue is released label Jan 17, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: throw `MockException` when `HttpClient` is not mockable#367

fix: throw `MockException` when `HttpClient` is not mockable#367
vbreuss merged 4 commits intomainfrom
topic/throw-mockexception-when-httpclient-is-not-mockable

vbreuss commented Jan 15, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Jan 17, 2026

Uh oh!

github-actions bot commented Jan 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

vbreuss commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Key Changes:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Benchmark Results

Uh oh!

github-actions bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

sonarqubecloud bot commented Jan 17, 2026

Quality Gate passed

Uh oh!

github-actions bot commented Jan 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vbreuss commented Jan 15, 2026 •

edited

Loading

github-actions bot commented Jan 15, 2026 •

edited

Loading

github-actions bot commented Jan 15, 2026 •

edited

Loading